Tools PRs that require review

0 comments

0 comments

0 comments

0 comments

As a reminder, [Dependabot Preview will be shut down on August 3rd, 2021][announcement]. You can merge this pull request to migrate to GitHub-native Dependabot. You can [read the docs][docs] to learn more about what's changing, as well as find out how to get support if you need help migrating. [announcement]: https://github.blog/2021-04-29-goodbye-dependabot-preview-hello-dependabot/ [docs]: https://docs.github.com/en/code-security/supply-chain-security/keeping-your-dependencies-updated-automatically/upgrading-from-dependabotcom-to-github-native-dependabot

0 comments

0 comments

0 comments

0 comments

[](https://cla-assistant.io/puppetlabs/dropsonde?pullRequest=3) All committers have signed the CLA.

After reviewing this and based on prior experience with other Ubuntu derivatives the codename of the OS `impish` is causing the script to fail because puppet repositories only support the main ubuntu codenames. Since each derivative has their own codename the agent package cannot be found which causes everything else to fail. Additionally, impish is too new for puppet support. Additionally, it appears the image has some initial apt-get lock problem that needs to be fixed in the upstream image. When we manually install this we just grab the 21.10 package and install it. I am guessing the puppet install script tries to piece together os information given the lsb data.

Related https://github.com/voxpupuli/beaker-module_install_helper/pull/33

0 comments

0 comments

Also, something that may be interesting in the doc for totally ignorant people (like me :-) ) is how I can run the tests for a specific version of puppet/ruby. As you can see, I have failures only for one version of that couple, but I am struggling in reproducing: https://github.com/puppetlabs/puppetlabs-stdlib/runs/3859406073?check_suite_focus=true I think ultimately what would be nice is a couple of commands, starting with `docker run`, which would put people in the correct environment they need to run `pdk bundle exec rake spec`. I tried reproducing what's in the workflow file (https://github.com/puppetlabs/puppetlabs-stdlib/blob/15e13b2b63f0f4b24e68a46cd4c2703682006d8f/.github/workflows/spec.yml#L77-L130) If I try to set the env variable `PUPPET_GEM_VERSION`, `pdk` complains ```bash root@943f4a62533a:/tmp/puppetlabs-stdlib# PUPPET_GEM_VERSION=6.0 pdk bundle exec rake spec SPEC=spec/functions/loadjson_spec.rb pdk (INFO): Using Ruby 2.7.3 pdk (INFO): Using Puppet 7.12.0 pdk (WARN): PUPPET_GEM_VERSION is not supported by PDK. Use the --puppet-version option on your PDK command or set the PDK_PUPPET_VERSION environment variable instead ``` If I try with `PDK_PUPPET_VERSION`, I have another issue ``` root@943f4a62533a:/tmp/puppetlabs-stdlib# PDK_PUPPET_VERSION=6.0 pdk bundle exec rake spec SPEC=spec/functions/loadjson_spec.rb pdk (INFO): Using Ruby 2.5.9 pdk (INFO): Using Puppet 6.0.10 pdk (WARN): FACTER_GEM_VERSION is not supported by PDK. Bundler could not find compatible versions for gem "puppet": In Gemfile: puppet (= 6.0.10) puppet-module-posix-system-r2.5 (~> 1.0) was resolved to 1.1.1, which depends on puppet_litmus (~> 0.20) was resolved to 0.30.0, which depends on bolt (>= 2.0.1, = 6.18.0) ```

0 comments

This looks like a valid reproducer. Now all we need is someone to write a patch to make the tests pass.

[](https://cla-assistant.io/puppetlabs/pdk-templates?pullRequest=462) All committers have signed the CLA.

0 comments

0 comments

0 comments

0 comments

0 comments

0 comments

[](https://cla-assistant.io/puppetlabs/Puppet.Dsc?pullRequest=198) All committers have signed the CLA.

Moving the files after your change to new filenames and then restoring the original files unchanged would go a long way.

@ekohl fixed it

I still think https://github.com/voxpupuli/puppet-syntax/pull/127#discussion_r517325284 is a comment that hasn't been answered.

It would be a breaking change, except that we already accidentally broke when [`puppet-syntax` released 3.0](https://github.com/voxpupuli/puppet-syntax/blob/master/CHANGELOG.md#v300-2020-05-09)

@sanfrancrisko at this point I'm uncertain what is expected. I'd like some guidance from the maintainers what the behavior should be. That means either changing the tests (as I suggested) or changing the code to pass the tests. Until I get that feedback I'm blocked.